Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

EVG-20818: Remove testIsolation for notification preferences #2063

Merged
merged 2 commits into from
Sep 27, 2023
Merged

EVG-20818: Remove testIsolation for notification preferences #2063

merged 2 commits into from
Sep 27, 2023

Conversation

sophstad
Copy link
Contributor

@sophstad sophstad commented Sep 26, 2023 •
edited
Loading

EVG-20818

Description

Let me know if this PR should do more than this!!

  • Remove testIsolation flag
  • Fix warnings caused by chaining clear() and type()

Testing

  • All tests in file passing

@sophstad sophstad changed the base branch from main to EVG-19395-feature-branch September 26, 2023 20:35
@sophstad sophstad requested a review from a team September 26, 2023 20:58
@sophstad sophstad marked this pull request as ready for review September 26, 2023 20:58
khelif96
khelif96 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@khelif96 khelif96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The evergreen tasks where failing because of an unrelated OOM. I restarted them and assuming they pass LGTM

cypress/integration/preferences/notifications.ts
Comment on lines +11 to +12
cy.dataCy("slack-member-id-field").clear();
cy.dataCy("slack-member-id-field").type("12345");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cypress
Copy link

cypress bot commented Sep 27, 2023

26 failed tests on run #12915 ↗︎

26 551 10 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Remove lint warnings
Project: Spruce Commit: 54daebdee2
Status: Failed Duration: 22:14 💡
Started: Sep 27, 2023 2:53 PM Ended: Sep 27, 2023 3:15 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@SupaJoon SupaJoon self-requested a review September 27, 2023 15:16
@sophstad sophstad merged commit 702fb3a into evergreen-ci:EVG-19395-feature-branch Sep 27, 2023
@sophstad sophstad deleted the EVG-20818 branch September 27, 2023 15:36
@cypress cypress bot mentioned this pull request Sep 27, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SupaJoon SupaJoon SupaJoon approved these changes

@khelif96 khelif96 khelif96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sophstad @khelif96 @SupaJoon